Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and Should to display Unsupported if no SBOM accessories found #20426

Merged
merged 2 commits into from
May 16, 2024

Conversation

xuelichao
Copy link
Contributor

Thank you for contributing to Harbor!

Fix and Should to display Unsupported if no SBOM accessories found

Issue being fixed

Fixes #20346

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@xuelichao xuelichao requested a review from a team as a code owner May 14, 2024 10:00
@xuelichao xuelichao added the release-note/ignore-for-release Do not include PR or Issue for release notes label May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.35%. Comparing base (b7b8847) to head (fb3b7a2).
Report is 191 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20426      +/-   ##
==========================================
- Coverage   67.56%   66.35%   -1.21%     
==========================================
  Files         991     1042      +51     
  Lines      109181   113176    +3995     
  Branches     2719     2836     +117     
==========================================
+ Hits        73768    75101    +1333     
- Misses      31449    34009    +2560     
- Partials     3964     4066     +102     
Flag Coverage Δ
unittests 66.35% <ø> (-1.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 568 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: xuelichao <xuel@vmware.com>
@stonezdj stonezdj merged commit 840d408 into goharbor:main May 16, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes target/2.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should this be Unsupported either for SBOM?
6 participants