Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix token service returning empty token on tls certificate issue without any error #20081

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix token service returning empty token on tls certificate issue without any error #20081

wants to merge 1 commit into from

Conversation

dee-kryvenko
Copy link

@dee-kryvenko dee-kryvenko commented Mar 3, 2024 •
edited

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #20080

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@dee-kryvenko
Fix token service returning empty token on tls certificate issue with…
22e580a 
…out any error

Signed-off-by: Dee Kryvenko <dee@selfcloud.tech>
@dee-kryvenko dee-kryvenko requested a review from a team as a code owner March 3, 2024 23:03
@dee-kryvenko dee-kryvenko mentioned this pull request Mar 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stonezdj stonezdj stonezdj approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@wy65701436 wy65701436

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

On tls issues with the certificate - token service returns empty token without any error or log record
6 participants
@dee-kryvenko @stonezdj @wy65701436 @zyyw @OrlinVasilev @AllForNothing