Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replacing gorilla mux in router.go #19965

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Its-Maniaco
Copy link

Replaced gorilla/mux with net/http

Partially Fixes #18077

Signed-off-by: Divya Pamecha <21123621+Its-Maniaco@users.noreply.github.com>
@Its-Maniaco
Copy link
Author

Its-Maniaco commented Feb 8, 2024

@zyyw @Vad1mo @stonezdj @OrlinVasilev I tried my hand at this. If this looks correct I can proceed with other instances.

@chlins
Copy link
Member

chlins commented Feb 13, 2024

Thanks for contributing! I recommend organizing all the references for this library into separate modules or components. This will make it easier to review each module or component individually for each PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the dependency of gorilla/mux.
6 participants