Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should this be Unsupported either for SBOM? #20346

Closed
zyyw opened this issue Apr 23, 2024 · 1 comment · Fixed by #20423 or #20426
Closed

Should this be Unsupported either for SBOM? #20346

zyyw opened this issue Apr 23, 2024 · 1 comment · Fixed by #20423 or #20426
Assignees
@stonezdj @xuelichao
Labels
area/SBOM target/2.11.0

Comments

@zyyw
Copy link
Contributor

zyyw commented Apr 23, 2024

How can we help you?
Screenshot 2024-04-23 at 6 23 48 PM
@xuelichao
Copy link
Contributor

xuelichao commented Apr 25, 2024 •
edited

The identify status is different due to the SBOM implementation is not same as Vulnerability.

  1. Vulnerability:
    Display 'Not supported' when artifact.addition_links[ADDITIONS.VULNERABILITIES] is not found
    This implementation is there before i touch the codes, i do not modify the logic for vulnerability.

  2. SBOM: There is not addition_links for SBOM.(confirmed with Stone before last GA)
    Display 'Not supported' when project.scanner.capabilities.support_sbom is false

    Leave your Comments once there is any updates on this.

stonezdj added a commit to stonezdj/harbor that referenced this issue Apr 30, 2024
@stonezdj
Add additional_link for sbom
4e0f722 
  fixes goharbor#20346

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
stonezdj added a commit to stonezdj/harbor that referenced this issue May 5, 2024
@stonezdj
Add additional_link for sbom
e7c7511 
  fixes goharbor#20346

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
stonezdj added a commit to stonezdj/harbor that referenced this issue May 6, 2024
@stonezdj
Add additional_link for sbom, skip scan image index
5de5e23 
  fixes goharbor#20346

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
stonezdj added a commit to stonezdj/harbor that referenced this issue May 13, 2024
@stonezdj
Add additional link for sboms
88204cb 
  fixes goharbor#20346

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
stonezdj added a commit to stonezdj/harbor that referenced this issue May 14, 2024
@stonezdj
Add additional link for sboms
1d9fce6 
  artifact object's addition_links has sboms item when it support to generate sbom
  fixes goharbor#20346

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
@stonezdj stonezdj mentioned this issue May 14, 2024
Merged
5 tasks
@xuelichao xuelichao mentioned this issue May 14, 2024
Merged
5 tasks
stonezdj added a commit to stonezdj/harbor that referenced this issue May 15, 2024
@stonezdj
Add additional link for sboms
42d5cad 
  artifact object's addition_links has sboms item when it support to generate sbom
  fixes goharbor#20346

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
stonezdj added a commit to stonezdj/harbor that referenced this issue May 15, 2024
@stonezdj
Add additional link for sboms
e81076b 
  artifact object's addition_links has sboms item when it support to generate sbom
  fixes goharbor#20346

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
stonezdj added a commit that referenced this issue May 15, 2024
@stonezdj
Add additional link for sboms (#20423)
2b4fe6c 
artifact object's addition_links has sboms item when it support to generate sbom
  fixes #20346

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stonezdj stonezdj

@xuelichao xuelichao

Labels
area/SBOM target/2.11.0
Projects
None yet
Milestone
No milestone
3 participants
@stonezdj @zyyw @xuelichao