Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HPA and Keda autoscaling #1756

Closed
wants to merge 1 commit into from
Closed

Conversation

xoanmi
Copy link
Contributor

@xoanmi xoanmi commented May 14, 2024

We are adding support for autoscale deployments with Horizontal Pod Autoscaling (HPA) and Keda.

This change is backward compatible since it adds new functionalities. With the default values the new settings have no effect.

Out of scope:

  • database: replicas is hardcoded to 1
  • redis: replicas is hardcoded to 1

close #1068

Signed-off-by: Joan Miquel Luque Oliver <joan.luque@dynatrace.com>
@xoanmi xoanmi changed the title Add support for HPA and Kepa autoscaling Add support for HPA and Keda autoscaling May 14, 2024
@xoanmi
Copy link
Contributor Author

xoanmi commented May 22, 2024

@zyyw @Vad1mo could you please take a look to this PR?

@Vad1mo
Copy link
Member

Vad1mo commented May 22, 2024

I am not sure if that isn't a bit too much for Harbor. HPA I can understand, but Keda. Any chance we can have it on the side/extension and not part of the main Helm chart?

@xoanmi
Copy link
Contributor Author

xoanmi commented May 22, 2024

I am not sure if that isn't a bit too much for Harbor. HPA I can understand, but Keda. Any chance we can have it on the side/extension and not part of the main Helm chart?

We would love to have Keda also supported to be able to scale the jobService based on the number of jobs in queue. IMHO is the same use case than the HPA but just with a different operator.

The problem with having it as a side extension is that we need to remove the ‘replicas’ object from the deployment. TBH I don't know how to do it without integrating it in the same chart… 😥

However, if you don't feel comfortable with that I can split the change into two different PRs so we could proceed with the HPA right away and proper discuss how to support Keda.

@zyyw
Copy link
Collaborator

zyyw commented May 30, 2024

This seems a little bit too much for goharbor/harbor-helm.

@zyyw zyyw closed this May 30, 2024
@xoanmi
Copy link
Contributor Author

xoanmi commented May 31, 2024

I have opened a new PR that adds support exclusively for HPA (#1765). I hope this aligns more closely with the project's scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add feature HPA on core, trivy and registry
3 participants