Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shader error on mobile when using LIGHT_VERTEX #91566

Merged
merged 1 commit into from May 6, 2024
Merged

Fix shader error on mobile when using LIGHT_VERTEX #91566

merged 1 commit into from May 6, 2024

Conversation

basicer
Copy link
Contributor

@basicer basicer commented May 4, 2024

Usage definition for LIGHT_VERTEX should be LIGHT_VERTEX_USED.

@basicer basicer requested a review from a team as a code owner May 4, 2024 18:03
@AThousandShips AThousandShips added this to the 4.3 milestone May 4, 2024
akien-mga
akien-mga approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that it's already correct in forward_plus and gl_compatibility. And not relevant for 4.2, this is new code in 4.3.

@akien-mga akien-mga changed the title Fix shader error on mobile when using LIGHT_VERTEX Fix shader error on mobile when using LIGHT_VERTEX May 6, 2024
@akien-mga akien-mga merged commit 275cdb8 into godotengine:master May 6, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug topic:shaders
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@basicer @akien-mga @clayjohn @AThousandShips