Fix EditorInspector crash when exiting #91538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitbdev
commented
May 3, 2024
Comment on lines
+4048
to
4049
| if (!sub_inspector && is_inside_tree()) { | ||
| get_tree()->disconnect("node_removed", callable_mp(this, &EditorInspector::_node_removed)); |
There was a problem hiding this comment.
With the current uses of EditorInspector, I don't think this condition will ever be true. As far as I know, all non-sub_inspectors will only be deleted on exit.
I left it here in case this ever changes in the future.
|
I was able to confirm on MacOS both the crash and that this appears to fix that crash. This does not appear to be related to the freeze on Windows that it is tied to, but it does fix the crash on MacOS (and presumably Linux). |
akien-mga
approved these changes
May 7, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue describes a freeze and a crash, this only fixes the crash when using
--import.#91168 relies on
EditorNode::is_exiting, but it is not set when using--importor--quitand maybe other ways of closing the Editor. Because of this, the check it used didn't work.I made the
node_removedsignal connection persist when the EditorInspector is out of the tree. This should fix the crash since the object is cleared by it beforeNOTIFICATION_PREDELETEis called.Needs testing on Linux.