Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Don't open AnimationLibrary as a scene #91522

Merged
merged 1 commit into from May 6, 2024

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented May 3, 2024

If opening an AnimationLibrary in the file dock and it is not imported the editor will treat it as a scene, rather than a resource. This fails to open it correctly.

The inspector might be confusing to users as the animation dock won't be valid, but it shouldn't be opened as a scene, further improvements might be desired but it looks like an oversight, especially as newly created resources show up in the inspector

@AThousandShips AThousandShips added this to the 4.3 milestone May 3, 2024
@AThousandShips AThousandShips requested a review from a team May 3, 2024 16:39
@AThousandShips AThousandShips requested a review from a team as a code owner May 3, 2024 16:39
@AThousandShips AThousandShips added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label May 3, 2024
@akien-mga akien-mga merged commit ecfcadb into godotengine:master May 6, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips deleted the anim_lib_improve branch May 6, 2024 13:23
@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release topic:animation topic:editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inspector doesn't appear for resources extending AnimationLibrary
3 participants