WIP: Fix compatibility gles3 driver loading GL_TEXTURE_2D_ARRAY and bptc rgba pixel size #91508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
|
still need to investigate a bit more on correct get_format_pixel_size values. |
semensanyok
force-pushed
the
fix-compatibility-gles3-driver-tex-image-2dArray-and-bptc-rgba-pixel-size
branch
2 times, most recently
from
b3a4566
to
9e9b84e
Compare
fixes godotengine#91118 marked CompareTo obsolete dropped CompareTo [-1,1] range Co-authored-by: Raul Santos <raulsntos@gmail.com>
Previously, _asset_parse_skins() would mess with the order of skin indices. However, the rest of the code expected these to match to ufbx skin indices. To fix this, retain the original skin indices in FBXState::original_skin_indices.
…igher. Also fix renderpass rect validation
semensanyok
force-pushed
the
fix-compatibility-gles3-driver-tex-image-2dArray-and-bptc-rgba-pixel-size
branch
from
23e12ab
to
39429a8
Compare
semensanyok
deleted the
fix-compatibility-gles3-driver-tex-image-2dArray-and-bptc-rgba-pixel-size
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #91365
CURRENT DIFF IS WRONG. IGNORE IT. UPDATE INCOMING ASAP.