Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid emitting signals if the animation is not ready to be processed #80367

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

garychia
Copy link
Contributor

@garychia garychia commented Aug 7, 2023

Fixes #80118.

@garychia garychia requested a review from a team as a code owner August 7, 2023 10:31
@Calinou Calinou added bug topic:animation cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Aug 7, 2023
@Calinou Calinou added this to the 4.2 milestone Aug 7, 2023
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@akien-mga akien-mga merged commit 06eade1 into godotengine:master Aug 17, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@garychia garychia deleted the anim_signals branch August 17, 2023 09:39
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 19, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3.

@hsandt
Copy link
Contributor

hsandt commented May 3, 2024

Could not confirm fix in v4.2beta4 and further. Please check the bug reboot: #91532 and test again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AnimationTree: animation_started signal is always emitted twice
5 participants