Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline all svg files to reduce network requests #805

Conversation

MichaelJRM
Copy link
Contributor

I've made a simple plugin to help inline the svg files and also minified all of the relevant ones

Slightly improves performance

@Calinou Calinou added enhancement topic:theme Issues and PRs related to styling and scripts of the frontend labels Feb 17, 2024
@MichaelJRM MichaelJRM force-pushed the inline-svgs-to-reduce-network-requests branch 3 times, most recently from d8ac1f9 to af09d23 Compare February 21, 2024 15:03
@MichaelJRM MichaelJRM force-pushed the inline-svgs-to-reduce-network-requests branch from af09d23 to 7379937 Compare February 21, 2024 15:04
@coppolaemilio
Copy link
Member

I don't think inlining svg files is the way to go. While it can be a good optimization for the amount of requests, it makes them hard to be replaced with other formats in the future. I think it is better to treat image elements as image elements and not as extra markup. This PR would also add another dependency that might require for us to maintain, and I would prefer that we keep it as simple as possible. Hope it makes sense, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement topic:theme Issues and PRs related to styling and scripts of the frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants