Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ClassDB::bind_static_vararg_method() to bind static variadic functions. #1248

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ttalexander2
Copy link

I needed to bind static variadic functions for a GDExtension project i'm working on, so I figured I'd create a PR.

Adds ClassDB::bind_static_vararg_method(). I tried by best to mimic the conventions in which member vararg methods are bound.

@ttalexander2 ttalexander2 requested a review from a team as a code owner September 21, 2023 20:29
@dsnopek
Copy link
Contributor

dsnopek commented Sep 22, 2023

Thanks, this is an interesting feature!

However, one of the design goals of godot-cpp is to provide (as much as possible) the same API as used internally by Godot modules. Since Godot's ClassDB doesn't support this function, it'll need to be added there first.

@Calinou Calinou added enhancement This is an enhancement on the current functionality topic:gdextension This relates to the new Godot 4 extension implementation labels Sep 22, 2023
@Calinou Calinou added this to the 4.x milestone Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement on the current functionality topic:gdextension This relates to the new Godot 4 extension implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants