Models: Supply missing models #221
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wonder how it lacks some models like "armadillo", "buddha" and "dragon" in the repository. The added models "armadillo" and "dragon" both come from [here](https://github.com/alecjacobson/common-3d-test-models) while "buddha" is from [here](https://gitlab.freedesktop.org/mesa/demos). After a quick test, the rotation quirk does not exist anymore on the armadillo and dragon, so related handling code could be removed safely. Signed-off-by: Luc Ma <luc@sietium.com>
lucmann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wonder that why it lacks "armadillo", "buddha" and "dragon" models in the repository. The three newly added models come from here. After a quick test, the previous quirks do not exist anymore on these models, so the code may get removed.