-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix context missing for test cases #19521
base: main
Are you sure you want to change the base?
Conversation
Sorry @mustard-mh , did manage to overlook this one. Will take a look this afternoon 🙇 |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
d92d4b9
to
9b8e5cf
Compare
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@mustard-mh Ugh, I did miss this PR again 😭 I blocked some time early next week to look into that, incl. this PR. 📅 |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
There're some places will print
mismatch
authorizaer
: it's testing mismatch casesorganization-service
: testing PERMISSION_DENIED / NOT_FOUND (i.e. member update settings, stranger find org)Important logic change:
organization-service
:addOrUpdateMember
with a new owner it will delete BUILT_IN one from org, add arunWithSubjectId
to make sure it's the new owner going to delete the member.workspace-starter
:failInstanceStart
it can happend no instance (at least in test case)Others
bearer-authxxx.spec.ts
: logic of expectError is not completeRelated Issue(s)
Fixed [internal chat]
How to test
Check changes of test cases (there're some note for changes on the Description section)
SubjectId mismatch
except what described on PR Description sectionDocumentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
. If enabled,with-preview
andwith-large-vm
will be enabled./hold