Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3285 'defaultDateStyle' config being ignored by rebaseEditor #3290

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TJohnsonSE
Copy link

@TJohnsonSE TJohnsonSE commented May 15, 2024

Description

I fixed issue #3285 where the interactive rebase editor ignores the user's preference of showing "relative" or "absolute" date formats. The fix is a simple ternary evaluation of the config setting in rebaseEditor.ts.

This seemed like a good introductory issue to fix and get some exposure to the codebase. Gitlens is a wonderful extension that I use every day, so I just want to contribute what I can to a project that I find incredibly useful.

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants