Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/drip transaction #1963

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

raskanskyz
Copy link
Contributor

@raskanskyz raskanskyz commented May 12, 2023

resolves #1618

  • chore: create prisma migration
  • chore: add "DRIP" selection to activities page + table

@raskanskyz
Copy link
Contributor Author

@dtslvr can you please review this?
I'm sure I missed a few things since i'm not too familiar with the project, yet :)

The only thing I tested was adding a "DRIP" transactoin both manually and by JSON import and I see that the transaction is added as expected and it also appears in the "Dividend Timeline".
What else needs to be verified?

@dtslvr
Copy link
Member

dtslvr commented May 21, 2023

Hi @raskanskyz

Thanks for your suggestion. I have finally found some time to review your PR.

I would like to understand exactly why a new DRIP type is needed. Can't the same scenario already be represented with a DIVIDEND and a BUY (with unitPrice 0) activity?

@raskanskyz
Copy link
Contributor Author

Hey @dtslvr,
Thanks for the review/reply!
You are correct although I think the unitPrice should be the price in which the stock was repurchased rather than 0.
This PR might actually be unnecessary. I was mainly looking for a convinient way to represent "DRIP" since it's a common term/type in most brokerages.
What I can do alternatively is update the JSON I want to import and split the "DRIP" transactions into DIVIDEND and BUY transactions.

@dtslvr
Copy link
Member

dtslvr commented May 22, 2023

Maybe you can create a test scenario @raskanskyz here to verify?

Something like ok-drip.json including BUY (initial buy), DIVIDEND, BUY (repurchase).

@bats77
Copy link

bats77 commented Nov 17, 2023

Hello, I had some comments about DRIP transaction, as example :
real dividend (based on published data) 100 =
first option : dividend = 100
second option : reinvestment on 15 stocks with a lasting dividend of 1,20
last option : revinvestment on 16 stocks with a buy operation consuming 10,4 cash

very close to Merge&Split transaction :
1 Google = 100 (new Google) at date + cash (bonus or reinvestment or nothing)
/ or / 19 At&t at date = 15 (new)At&t + 3 WarnerMedia + cash (bonus or reinvestment);

Nice and promising application by the way, congrats 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants