Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect usage of github.event #7103

Closed
wants to merge 1 commit into from

Conversation

CISC
Copy link
Contributor

@CISC CISC commented May 6, 2024

Discovered this while debugging #7034

Warning: This may change current behavior as all these evaluated to null before!

Discovered this while debugging ggerganov#7034

**Warning**: This may change current behavior as all these evaluated to null before!
@CISC
Copy link
Contributor Author

CISC commented May 7, 2024

I just noticed github.event.inputs is part of workflow_dispatch payload, so not technically incorrect after all, but unnecessarily long at least. Also has this difference:

The workflow will also receive the inputs in the github.event.inputs context. The information in the inputs context and github.event.inputs context is identical except that the inputs context preserves Boolean values as Booleans instead of converting them to strings. The choice type resolves to a string and is a single selectable option.

Additionally I can see that github.event.schedule is also defined even though it's apparently not documented:

##[debug]..Evaluating success:
##[debug]..=> true
##[debug]..Evaluating Or:
##[debug]....Evaluating Index:
##[debug]......Evaluating Index:
##[debug]........Evaluating github:
##[debug]........=> Object
##[debug]........Evaluating String:
##[debug]........=> 'event'
##[debug]......=> Object
##[debug]......Evaluating String:
##[debug]......=> 'schedule'
##[debug]....=> '2 4 * * *'
##[debug]..=> '2 4 * * *'

@CISC CISC closed this May 7, 2024
@CISC CISC deleted the incorrect-github-event branch May 7, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant