docs: Fix typo and update description for --embeddings flag #7026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phymbert
reviewed
May 1, 2024
mofosyne
added
documentation
mofosyne
approved these changes
May 13, 2024
mofosyne
approved these changes
May 14, 2024
|
Will merge sometimes today if no one objects. |
- Change '--embedding' to '--embeddings' in the README - Update the description to match the latest --help output - Added a caution about defining physical batch size
teleprint-me
pushed a commit
to teleprint-me/llama.cpp
that referenced
this pull request
May 17, 2024
…v#7026) - Change '--embedding' to '--embeddings' in the README - Update the description to match the latest --help output - Added a caution about defining physical batch size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I noticed a discrepancy between the server's README and the
--helpoutput of the current server version.This commit updates the server's README to accurately reflect the latest
--helpoutput regarding the--embeddingsflag:"--embeddings: Enable embedding vector output. Default: disabled"