-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for the ArcticForCausalLM. #7020
Merged
fairydreaming
merged 19 commits into
ggerganov:master
from
fairydreaming:snowflake-arctic-clean
May 24, 2024
Merged
Changes from 12 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
71d8bd6
Added support for the snowflake-arctic model.
sszymczy c95013d
Whitespace formatting fixes.
sszymczy c6f15a7
Read vocabulary for ArcticForCausalLM from sentencepiece model instea…
sszymczy 0cffda8
Moved ArcticModel to the end of the file.
sszymczy f3d1227
Merge branch 'ggerganov:master' into snowflake-arctic-clean
fairydreaming a892571
Applied changes from upstream PR: save memory with lazy evaluation #7…
sszymczy 4ebb52c
Replaced prints with logger calls.
sszymczy 9acc3ec
Removed unnecessary method - LlamaModel.permute is used instead.
sszymczy f4421f7
convert-hf : Corrected sentencepiece API calls.
sszymczy 7a5df5f
Merge branch 'ggerganov:master' into snowflake-arctic
sszymczy 85263f0
Minor fixes after merging.
sszymczy 5b2be25
gguf-py : Moved non-conflicting block mappings from architecture-spec…
sszymczy 5553226
Reordered tensors for visual consistency.
sszymczy f93acb5
llama : Removed usage of bias tensors in LLM_ARCH_ARCTIC, as they are…
sszymczy b53fd29
Reordered tensors for visual consistency.
sszymczy eb58c4b
Merge remote-tracking branch 'upstream/master' into snowflake-arctic-…
sszymczy a1a5508
llama : Replaced obsolete ggml_rope_custom() calls with ggml_rope_ext().
sszymczy 3aa20e1
Merge remote-tracking branch 'upstream/master' into snowflake-arctic-…
sszymczy 602c80d
llama : fix whitespace formatting
sszymczy File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the actual numbers associated to the enum values of
MODEL_TENSOR
don't really matter (their names (fromTENSOR_NAMES
) are used instead in GGUF), maybeFFN_NORM_EXP
could be placed right beforeFFN_GATE_EXP
, a bit likeFFN_NORM
is right beforeFFN_GATE
, for consistency.If this is changed, it should also be placed similarly in
TENSOR_NAMES
andMODEL_TENSORS[MODEL.ARCTIC]
ingguf-py/gguf/constants.py
as well as in thellm_tensor
enum, theLLM_TENSOR_NAMES
mapping, and thellama_layer
struct (and maybe theLLM_ARCH_ARCTIC
case inllm_load_tensors
?) inllama.cpp
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the order as requested, but in llama_layer struct the order is different, so I didn't touch it. In llm_load_tensors I think it was already in the requested order.