64 bit image atomics #5537
Draft
64 bit image atomics #5537
+2,547
−163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than introducing an entirely new statement variant `AtomicNoResult`, make `Statement::Atomic::result` an `Option`. This reduces the patch size by about a third, and has no effect on snapshot output other than the direct IR dumps. In HLSL output, don't bother to generated "discard" temporaries for functions where the final `original_value` parameter is not required. This improves snapshot output. Improve documentation for `Expression::AtomicResult`, `Statement::Atomic`, and the new `valid::Capabilities` flags. Rewrite `Atomic` statement validation. Consolidate validation of `AtomicResult` expressions with this; gfx-rs#5771 ensures that there is indeed some `Atomic` statement referring to every `AtomicResult` expression, so we can be sure it will be validated. Fixes gfx-rs#5742.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Part of an incoming series of PRs needed by #5123
Others in this series: #5155 #5154 #5383
Addresses #4424
Depends on #5383
Ultimately for bevy meshlets pipeline bevyengine/bevy#10164
Description
No image atomics available. I'm opening this early to show the current approach. I think atomic image operations should be added as a Image Store variant, however, as it reuses most of the infrastructure. Im thinking about an enum like
ImageOperation { Store, Atomic(AtomicFunctionNoReturn) }.Testing
WIP
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.