-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(insights): add status and retry filtering to queue sample panel #71136
Merged
+192
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Automatically applied to PRs that change frontend components
label
May 17, 2024
Bundle ReportChanges will increase total bundle size by 5.85kB ⬆️
|
JonasBa
reviewed
May 18, 2024
static/app/views/performance/queues/destinationSummary/messageSpanSamplesPanel.tsx
Outdated
Show resolved
Hide resolved
static/app/views/performance/queues/destinationSummary/messageSpanSamplesPanel.tsx
Outdated
Show resolved
Hide resolved
static/app/views/performance/queues/destinationSummary/messageSpanSamplesPanel.tsx
Outdated
Show resolved
Hide resolved
gggritso
reviewed
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense! A few stray comments, but nothing major
static/app/views/performance/queues/destinationSummary/messageSpanSamplesPanel.tsx
Outdated
Show resolved
Hide resolved
static/app/views/performance/queues/destinationSummary/messageSpanSamplesPanel.tsx
Outdated
Show resolved
Hide resolved
static/app/views/performance/queues/destinationSummary/messageSpanSamplesPanel.tsx
Outdated
Show resolved
Hide resolved
static/app/views/performance/queues/destinationSummary/messageSpanSamplesPanel.tsx
Outdated
Show resolved
Hide resolved
KevinL10
force-pushed
the
kevinliu/feat/queue-sample-panel-filter
branch
from
May 21, 2024 18:18
73ab9a2
to
097beaf
Compare
gggritso
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds status and retry filtering to the queue sample panel. Retry filters are only available for consumers.