chore(hybridcloud) Expand OrgMapping update payload #71119
Merged
+60
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our schema generation and validation tooling doesn't work well with tuple values. Replace this tuple with an 'Optional' that retains the ability to preserve 'undefined' vs 'defined and none'. Refs HC-1190
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #71119 +/- ##
==========================================
+ Coverage 77.89% 77.91% +0.02%
==========================================
Files 6529 6526 -3
Lines 290909 290386 -523
Branches 50338 50229 -109
==========================================
- Hits 226591 226254 -337
+ Misses 58096 57896 -200
- Partials 6222 6236 +14
|
GabeVillalobos
approved these changes
May 22, 2024
| @@ -32,7 +36,8 @@ class RpcOrganizationMappingUpdate(RpcModel): | |||
| # When not set, no change to customer id performed, | |||
| # when set with a tuple, the customer_id set to either None or the string | |||
| # that is the first element. | |||
| customer_id: tuple[str | None] | None = None | |||
| # Using a tuple is deprecated and will be removed. | |||
| customer_id: tuple[str | None] | CustomerId | None = None | |||
There was a problem hiding this comment.
What's the benefit of using a class here vs just passing an int? Will we be adding more attributes to it in the future?
There was a problem hiding this comment.
The current implementation uses a single element tuple of str | None to indicate a value/explicit None vs an implicit None because the key is undefined. The class lets us wrap None and maintain the same semantics as the tuple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our schema generation and validation tooling doesn't work well with tuple values. Replace this tuple with an 'Optional' that retains the ability to preserve 'undefined' vs 'defined and none'.
Refs HC-1190