Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(issue-stream): Ensure that empty state is shown correctly when all projects are selected #71110

Merged
merged 1 commit into from
May 20, 2024

Conversation

malwilley
Copy link
Member

@malwilley malwilley commented May 17, 2024

With project="-1", the projects endpoint was failing. And because the component was not handling errors, it landed in a forever loading state. This fixes the endpoint so that it no longer fails with project="-1" and handles errors correctly to prevent this from happening again.

@malwilley malwilley requested review from scttcper and a team May 17, 2024 15:16
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 17, 2024
@malwilley malwilley merged commit dfc0962 into master May 20, 2024
44 checks passed
@malwilley malwilley deleted the malwilley/fix/all-projects-no-events branch May 20, 2024 15:56
cmanallen pushed a commit that referenced this pull request May 21, 2024
…l projects are selected (#71110)

With `project="-1"`, the projects endpoint was failing. And because the
component was not handling errors, it landed in a forever loading state.
This fixes the endpoint so that it no longer fails with `project="-1"`
and handles errors correctly to prevent this from happening again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants