chore(staff): Convert sudo modal to functional #71100
Conversation
github-actions
bot
added
the
Scope: Frontend
michellewzhang
force-pushed
the
seiji/chore/convert-sudo-modal-to-functional
branch
from
c4ee5d1
to
5bb1a57
Compare
michellewzhang
force-pushed
the
seiji/chore/convert-sudo-modal-to-functional
branch
from
5bb1a57
to
9bbc583
Compare
schew2381
force-pushed
the
seiji/chore/convert-sudo-modal-to-functional
branch
from
9bbc583
to
ee1d485
Compare
github-actions
bot
added
the
Scope: Backend
michellewzhang
force-pushed
the
seiji/chore/convert-sudo-modal-to-functional
branch
from
ee1d485
to
9bbc583
Compare
schew2381
removed
the
Scope: Backend
| closeModal, | ||
| isSuperuser, | ||
| location, | ||
| needsReload, | ||
| router, | ||
| retryRequest, | ||
| api, | ||
| Header, | ||
| Body, |
There was a problem hiding this comment.
Do we need all of these to be props? For example, we could change router to:
const router = useRouter();By importing components and/or using hooks for these props, it helps keep the components signature cleaner and makes the component a little easier to use.
There was a problem hiding this comment.
useRouter is deprecated, what should be used instead? we can replace router, api, and location with hooks
| try { | ||
| await logout(api); | ||
| } catch { | ||
| // ignore errors | ||
| } | ||
| window.location.assign(this.getAuthLoginPath()); | ||
| window.location.assign(getAuthLoginPath()); |
There was a problem hiding this comment.
rather than using window.location can we use router to change the history? The difference for the user would be a full page load vs a react page transition. (feel free to ignore this if we need to do a full page load to validate cookies / auth)
There was a problem hiding this comment.
We need one more request to validate 鉀筹笍
Change this component to functional in order to try using
useContextin a future PR.I removed
busybecause it wasn't used anywhere 馃Props to @michellewzhang for carrying most of the work on this 馃槑