-
-
Notifications
You must be signed in to change notification settings - Fork 35.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(curriculum): prevent hardcoding palidrome checker answers #54816
fix(curriculum): prevent hardcoding palidrome checker answers #54816
Conversation
...thms-and-data-structures-22/build-a-palindrome-checker-project/build-a-palindrome-checker.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Ilenia <26656284+ilenia-magoni@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
...thms-and-data-structures-22/build-a-palindrome-checker-project/build-a-palindrome-checker.md
Outdated
Show resolved
Hide resolved
I think one more test is required, to cover generated non-palindrome. Otherwise there's option to hardcode the specific cases and anything else consider as a palindrome. |
Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to say that the not palindrome could be a palindrome, but you are removing used letters, good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Checklist:
main
branch of freeCodeCamp.Ref #54063
This generates one random phrase consisting of both numbers and lowercase letters. It'd be extremely difficult to hard-code a solution for this test. It'd be a lot less work just solving the problem rather than predicting whatever is generated.