test: use challenge with visible buttons for spec #54566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround for the fact that element.scrollIntoView() doesn't work for elements inside the editor. This 'fix' simply uses a challenge with a shorter description meaning that the buttons are already visible.
github-actions
bot
added
the
scope: tools/scripts
|
This does not work with the new page: await page.keyboard.insertText(
'<html><body><h1>CatPhotoApp</h1><h2>Cat Photos</h2></body></html>'
);
await page.getByRole('button', { name: 'Check Your Code' }).click(); |
|
Thanks @ShaunSHamilton. It seems to be working now. |
ShaunSHamilton
requested changes
Apr 29, 2024
naomi-lgbt
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for the fact that element.scrollIntoView() doesn't work for
elements inside the editor. This 'fix' simply uses a challenge with a
shorter description meaning that the buttons are already visible.
Checklist:
mainbranch of freeCodeCamp.Closes #XXXXX