Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't use get_list & get_all interchangeably (backport #33916) #41539

Closed

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 19, 2024

Changes

  • Remove DatabaseQuery permission checks on aggregated "`tabPurchase Receipt Item`.qty" value
  • Remove DatabaseQuery permission checks in get_returned_qty_map_for_row query

For frappe/frappe#19533


This is an automatic backport of pull request #33916 done by Mergify.

value

(cherry picked from commit 3518d4b)

# Conflicts:
#	erpnext/stock/doctype/purchase_receipt/purchase_receipt.py
Copy link
Contributor Author

mergify bot commented May 19, 2024

Cherry-pick of 3518d4b has failed:

On branch mergify/bp/version-14-hotfix/pr-33916
Your branch is up to date with 'origin/version-14-hotfix'.

You are currently cherry-picking commit 3518d4be1d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   erpnext/stock/doctype/purchase_receipt/purchase_receipt.py

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label May 19, 2024
@gavindsouza gavindsouza deleted the mergify/bp/version-14-hotfix/pr-33916 branch May 28, 2024 16:13
@gavindsouza
Copy link
Collaborator

Not sure if this was triggered by someone, but I think this was ported to v14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant