-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correcting balance sheet calculation for zero liabilities and equity #41497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nihantra-Patel
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
May 16, 2024 09:25
nabinhait
approved these changes
Jun 3, 2024
earona
pushed a commit
to NovigoTechnology/erpnext
that referenced
this pull request
Jun 6, 2024
## [15.0.1](v15.0.0-Novigo...v15.0.1-Novigo) (2024-06-06) ### Bug Fixes * Add posting date to key for consolidated view ([2c164b4](2c164b4)) * bank account no fieldname mismatch ([frappe#41778](https://github.com/NovigoTechnology/erpnext/issues/41778)) ([d163dbe](d163dbe)) * **Company:** Allow Equity type account in unrealised exchange gain/loss account ([frappe#41740](https://github.com/NovigoTechnology/erpnext/issues/41740)) ([d30c797](d30c797)) * completed DC will not appear in a delivery trip ([frappe#41655](https://github.com/NovigoTechnology/erpnext/issues/41655)) ([4f0214d](4f0214d)) * convert percentage from str to float ([frappe#41766](https://github.com/NovigoTechnology/erpnext/issues/41766)) ([71f5470](71f5470)) * Copy depreciation schedule on asset split only if it exists ([frappe#41775](https://github.com/NovigoTechnology/erpnext/issues/41775)) ([689e1cf](689e1cf)) * correcting balance sheet calculation for zero liabilities and equity ([frappe#41497](https://github.com/NovigoTechnology/erpnext/issues/41497)) ([3c33135](3c33135)) * Do no apply pricing rule on qty change for mapped docs ([2b12421](2b12421)) * get assets received but not billed account only if any asset item is received (backport [frappe#41734](https://github.com/NovigoTechnology/erpnext/issues/41734)) ([frappe#41750](https://github.com/NovigoTechnology/erpnext/issues/41750)) ([c3ae5bc](c3ae5bc)) * Ignore disabling default currency field while creating new company ([frappe#41699](https://github.com/NovigoTechnology/erpnext/issues/41699)) ([80f6228](80f6228)) * incorrect accumulated depr amount in asset depr ledger ([frappe#41654](https://github.com/NovigoTechnology/erpnext/issues/41654)) ([a8fc32d](a8fc32d)) * incorrect batch selection while sales return ([frappe#41768](https://github.com/NovigoTechnology/erpnext/issues/41768)) ([cb6d8af](cb6d8af)) * link opportunity in prospect after creating opportunity from prospect ([frappe#41769](https://github.com/NovigoTechnology/erpnext/issues/41769)) ([12e48f0](12e48f0)) * local var referenced before assignment ([frappe#41780](https://github.com/NovigoTechnology/erpnext/issues/41780)) ([4ff3e6c](4ff3e6c)) * **minor:** corrected wrong filter condition ([frappe#41755](https://github.com/NovigoTechnology/erpnext/issues/41755)) ([60eb03a](60eb03a)) * payment term when creating PO from SO ([frappe#41376](https://github.com/NovigoTechnology/erpnext/issues/41376)) ([441596f](441596f)) * Select both account number and company in the account form ([frappe#41731](https://github.com/NovigoTechnology/erpnext/issues/41731)) ([5a75c84](5a75c84)) * set expense account as Assets RBNB only if it is booked in linked PR (backport [frappe#41368](https://github.com/NovigoTechnology/erpnext/issues/41368)) ([frappe#41733](https://github.com/NovigoTechnology/erpnext/issues/41733)) ([a2039ba](a2039ba)) * **stock settings:** Allowed any number in stock frozen upto days field ([frappe#41736](https://github.com/NovigoTechnology/erpnext/issues/41736)) ([740c495](740c495)) * TypeError: 'float' object is not iterable ([frappe#41758](https://github.com/NovigoTechnology/erpnext/issues/41758)) ([cf508ce](cf508ce)) * Use full name instead of abbreviation ([frappe#41738](https://github.com/NovigoTechnology/erpnext/issues/41738)) ([9a3569f](9a3569f)) * **Vehicle:** allow doc renaming and add test ([frappe#41729](https://github.com/NovigoTechnology/erpnext/issues/41729)) ([c76f466](c76f466))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version 15
fixes: #41488 and https://discuss.frappe.io/t/provisional-profit-loss-credit-shows-0-despite-total-asset-value-in-balance-sheet-report/123335
Before:
After: