Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create custom field for accounting dimensions only if the field not exists already #41484

Merged
merged 1 commit into from
May 20, 2024

Conversation

nabinhait
Copy link
Member

User has create accounting dimension based on purchase invoice. But purchase invoice field already exists in Asset Repair doctype. And that's why, the patch was failing.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label May 15, 2024
@nabinhait nabinhait added backport version-15-hotfix and removed needs-tests This PR needs automated unit-tests. labels May 15, 2024
@nabinhait nabinhait force-pushed the acc-dimensions-asset-repair branch from 75ce4fd to 0661ac7 Compare May 20, 2024 12:31
@nabinhait nabinhait enabled auto-merge (squash) May 20, 2024 12:31
@nabinhait nabinhait changed the title patch: create custom field for accounting dimensions only if the field not exists already fix: create custom field for accounting dimensions only if the field not exists already May 20, 2024
@nabinhait nabinhait merged commit dfdb95b into frappe:develop May 20, 2024
14 checks passed
mergify bot pushed a commit that referenced this pull request May 20, 2024
…d not exists already (#41484)

fix: create custom field for accounting dimensions only if the field not exists already
(cherry picked from commit dfdb95b)
@nabinhait
Copy link
Member Author

@Mergifyio backport version-15-hotfix

Copy link
Contributor

mergify bot commented May 20, 2024

backport version-15-hotfix

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant