feat(autoname): Make deferred naming for GL entry and Stock Ledger entry optional #41472
+66
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stock Ledger Entry and GL Entry use a naming system where the final name is only generated by a cron job, which makes the naming unstable. This has the tendency to break external applications relying on the naming scheme being final. Therefore this should be an optional feature, which can be enabled in the accounts settings if needed due to low database performance. Signed-off-by: Benedek Major <benedek.major@mabeney.com>
Bensikrac
requested review from
rohitwaghchaure,
s-aga-r,
deepeshgarg007 and
ruthra-kumar
as code owners
|
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
|
Could someone approve the workflows? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stock Ledger Entry and GL Entry use a naming system where the final name is only generated by a scheduled job, which makes the naming unstable. This has the tendency to break external applications relying on the naming scheme being final, due to hooks on document submission. Therefore this should be an optional feature, which can be enabled in the accounts settings if needed due to low database performance. This feature also causes a lot of confusion and not much benefit currently, which means by default this should be off.
This got included in #16358
closes #36337by giving the fix of names being immediately aligned to the scheme