fix: product filters value sorting #41465
Open
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: release v14
## [14.67.2](frappe/erpnext@v14.67.1...v14.67.2) (2024-04-17) ### Bug Fixes * barcode not fetched on selection of item (backport [frappe#40814](frappe#40814)) ([frappe#41027](frappe#41027)) ([0bee921](frappe@0bee921)) * Delayed Order Report not working (backport [frappe#41037](frappe#41037)) ([frappe#41038](frappe#41038)) ([e956dbb](frappe@e956dbb)) * Don't call get_fiscal_year if setup is not done yet ([59cea9f](frappe@59cea9f)) * Don't set delivery date as today while making SO from Quotation ([b47e224](frappe@b47e224)) * exclude some query builder lines from ruff rules ([2425119](frappe@2425119)) * expense account set as COGS for stock entry Material Issue (backport [frappe#41026](frappe#41026)) ([frappe#41028](frappe#41028)) ([153e0ba](frappe@153e0ba)) * get address if multiple companies ([c2b6b64](frappe@c2b6b64)) * get address if multiple companies ([0493872](frappe@0493872)) * **gp:** SLEs not fetched for correct warehouse ([97e7b3f](frappe@97e7b3f)) * incorrect exc gain/loss for PE against JE for payable accounts ([50a74ee](frappe@50a74ee)) * Resolve merge conflicts ([cc925ae](frappe@cc925ae)) * Subcontracting Receipt GL Entries (backport [frappe#40773](frappe#40773)) ([frappe#40978](frappe#40978)) ([c2c4548](frappe@c2c4548)) * test cases ([79e23da](frappe@79e23da)) * **treewide:** manual ruff fixes ([b087fb3](frappe@b087fb3)) * use 'eq' and isnull() on qb conditions ([b4ed2d2](frappe@b4ed2d2))
chore: release v14
# [14.68.0](frappe/erpnext@v14.67.2...v14.68.0) (2024-04-24) ### Bug Fixes * account and stock manager read perm ([03ce9ee](frappe@03ce9ee)) * allow Employee role to select cost center & project (accounting dimensions) (backport [frappe#41160](frappe#41160)) ([frappe#41161](frappe#41161)) ([bb48440](frappe@bb48440)) * do not add actual expense twice for validating budget ([ec4f07f](frappe@ec4f07f)) * don't attempt to set gender from salutation (backport [frappe#40997](frappe#40997)) ([frappe#41072](frappe#41072)) ([5d05bf8](frappe@5d05bf8)) * Missing args while fetching items from delivery note ([0df80ad](frappe@0df80ad)) * Multiple partial payment requests against Purchase Invoice ([f1b75e8](frappe@f1b75e8)) * Party type in Payment Order ([a2e1d13](frappe@a2e1d13)) * Permission for lower dedcution certificate ([a22be6f](frappe@a22be6f)) * Test case ([5aef9d2](frappe@5aef9d2)) * validate uom is integer for PR item (backport [frappe#41074](frappe#41074)) ([frappe#41076](frappe#41076)) ([9d0c1dc](frappe@9d0c1dc)) ### Features * Available batches report as on specific date ([8868cb1](frappe@8868cb1)) * show expense breakup ([f087ec8](frappe@f087ec8)) ### Performance Improvements * stock ageing and batch-wise balance history report ([6017e7a](frappe@6017e7a))
Mode of Payment is given precedence over company/party bank account (cherry picked from commit 4aef969)
…41142 fix: mode of payment has precedance in Payment Entry (backport frappe#41142)
## [14.68.1](frappe/erpnext@v14.68.0...v14.68.1) (2024-04-25) ### Bug Fixes * mode of payment has precedance ([7e52f72](frappe@7e52f72))
(cherry picked from commit 113351e)
…41174 perf: timeout issue while submitting purchase receipt (v14) (backport frappe#41174)
## [14.68.2](frappe/erpnext@v14.68.1...v14.68.2) (2024-04-26) ### Performance Improvements * timeout issue while submitting purchase receipt (v14) ([c93840e](frappe@c93840e))
chore: release v14
# [14.69.0](frappe/erpnext@v14.68.2...v14.69.0) (2024-05-02) ### Bug Fixes * 'NoneType' object has no attribute '_read_rowdata_packet_unbuffered' ([949aa93](frappe@949aa93)) * args when get the delivery note in delivery trip ([abe64aa](frappe@abe64aa)) * args when get the delivery note in delivery trip ([1a7b3c4](frappe@1a7b3c4)) * display term name for single term invoices ([58b68b7](frappe@58b68b7)) * duplicate column in the stock ledger report ([3fcdcef](frappe@3fcdcef)) * handle stock balance unbuffered_cursor error (backport [frappe#41186](frappe#41186)) ([frappe#41187](frappe#41187)) ([59010c9](frappe@59010c9)) * incorrectly applying TDS when Advance is in previous FY ([eb22fb9](frappe@eb22fb9)) * mode of payment has precedance ([33d38ba](frappe@33d38ba)) * multiple pricing rules with discount amount and discount percentage not working ([frappe#41211](frappe#41211)) ([54313b5](frappe@54313b5)) * negative stock qty error for stock reconciliation ([frappe#41283](frappe#41283)) ([9aa054c](frappe@9aa054c)) * permission issue when user permission restricts on company ([45c4167](frappe@45c4167)) * validation to prevent overallocation ([8318286](frappe@8318286)) ### Features * allow to do reposting for all stock transactions (audit) (backport [frappe#41165](frappe#41165)) ([frappe#41205](frappe#41205)) ([1e13193](frappe@1e13193)) ### Performance Improvements * timeout issue while submitting purchase receipt (v14) ([113351e](frappe@113351e))
chore: release v14
## [14.69.1](frappe/erpnext@v14.69.0...v14.69.1) (2024-05-09) ### Bug Fixes * added brand column in Warehouse wise Item Balance Age and Value … (backport [frappe#41280](frappe#41280)) ([frappe#41281](frappe#41281)) ([d727c52](frappe@d727c52)) * Cost center not getting saved in PSOA ([e82ea12](frappe@e82ea12)) * filter validation for batch-wise balance history report (backport [frappe#41356](frappe#41356)) ([frappe#41360](frappe#41360)) ([339256b](frappe@339256b)) * incorrect query for Purchase Invoice rate in GP ([93b30d9](frappe@93b30d9)) * missing Item Name on Save for Quotation created from Item (backport [frappe#41233](frappe#41233)) ([frappe#41303](frappe#41303)) ([a26ae64](frappe@a26ae64)) * pricing rule rounding ([d2ce927](frappe@d2ce927)) * reset rate for serial batch supplied items ([frappe#41293](frappe#41293)) ([cd33199](frappe@cd33199)) ### Performance Improvements * index on item code for the Pick List Item doctype (backport [frappe#41357](frappe#41357)) ([frappe#41362](frappe#41362)) ([4647ec8](frappe@4647ec8))
|
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Currently when adding filter in E Commerce Settings either Field Filters (Categories) or Attribute Filters section. The order of the values is not sorted. (See example image below)
Proposed fix:
Sort values returned in class ProductFiltersBuilder