-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Item-wise Sales and Purchase register with no item codes #41373 #41424
Merged
deepeshgarg007
merged 6 commits into
frappe:develop
from
Poorvi-R-Bhat:item-code-purchase-sales-register
Jun 9, 2024
Merged
fix: Item-wise Sales and Purchase register with no item codes #41373 #41424
deepeshgarg007
merged 6 commits into
frappe:develop
from
Poorvi-R-Bhat:item-code-purchase-sales-register
Jun 9, 2024
+207
−133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Poorvi-R-Bhat
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
May 13, 2024 04:11
This was referenced Jun 9, 2024
This was referenced Jun 9, 2024
Merged
deepeshgarg007
added a commit
that referenced
this pull request
Jun 9, 2024
…-41424 fix: Item-wise Sales and Purchase register with no item codes (#41424)
deepeshgarg007
added a commit
that referenced
this pull request
Jun 9, 2024
…-41424 fix: Item-wise Sales and Purchase register with no item codes (#41424)
deepeshgarg007
added a commit
that referenced
this pull request
Jun 10, 2024
fix: Item-wise Sales and Purchase register with no item codes (#41424)
deepeshgarg007
added a commit
that referenced
this pull request
Jun 10, 2024
fix: Item-wise Sales and Purchase register with no item codes (#41424)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport version-14-hotfix
backport to version 14
backport version-15-hotfix
needs-tests
This PR needs automated unit-tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshot for the Sales Register:
Screenshots for the Item-wise Sales Register
Before:
After:
Now the Item-wise Sales Register Displays the Sales Invoices which does not have the Item Code.
Screenshot for the Purchase Register:
Screenshots for the Item-wise Purchase Register
Before:
After:
Now the Item-wise Purchase Register Displays the Purchase Invoices which does not have the Item Code.