Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cast): send 4844 support #7823

Merged
merged 13 commits into from
May 21, 2024
Merged

Conversation

yash-atreya
Copy link
Collaborator

@yash-atreya yash-atreya commented Apr 30, 2024

Motivation

4844 Support for cast send

Solution

Added --blob flag which should be coupled with the --path flag pointing to the blob data.

@yash-atreya yash-atreya self-assigned this Apr 30, 2024
@yash-atreya yash-atreya changed the title feat(cast-send): 4844 support boilerplate feat(cast-send): 4844 support Apr 30, 2024
@Evalir Evalir mentioned this pull request May 3, 2024
10 tasks
@yash-atreya yash-atreya marked this pull request as ready for review May 3, 2024 23:46
@yash-atreya yash-atreya changed the title feat(cast-send): 4844 support feat(cast): send 4844 support May 3, 2024
@yash-atreya yash-atreya changed the title feat(cast): send 4844 support [WIP] feat(cast): send 4844 support May 3, 2024
crates/cast/bin/cmd/send.rs Outdated Show resolved Hide resolved
crates/cast/bin/cmd/send.rs Outdated Show resolved Hide resolved
crates/cast/bin/cmd/send.rs Outdated Show resolved Hide resolved
@yash-atreya yash-atreya changed the title [WIP] feat(cast): send 4844 support feat(cast): send 4844 support May 7, 2024
@yash-atreya yash-atreya requested a review from DaniPopes May 7, 2024 18:12
@yash-atreya
Copy link
Collaborator Author

@mattsse ptal

Cargo.lock Outdated Show resolved Hide resolved
crates/cli/src/opts/transaction.rs Outdated Show resolved Hide resolved
@yash-atreya
Copy link
Collaborator Author

@DaniPopes @mattsse good to merge?

@yash-atreya yash-atreya merged commit 003d088 into foundry-rs:master May 21, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants