-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cast): send 4844 support #7823
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-atreya
changed the title
feat(cast-send): 4844 support boilerplate
feat(cast-send): 4844 support
Apr 30, 2024
yash-atreya
changed the title
feat(cast-send): 4844 support
feat(cast): send 4844 support
May 3, 2024
yash-atreya
changed the title
feat(cast): send 4844 support
[WIP] feat(cast): send 4844 support
May 3, 2024
Evalir
reviewed
May 4, 2024
DaniPopes
reviewed
May 4, 2024
yash-atreya
changed the title
[WIP] feat(cast): send 4844 support
feat(cast): send 4844 support
May 7, 2024
@mattsse ptal |
DaniPopes
reviewed
May 7, 2024
@DaniPopes @mattsse good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
4844 Support for cast send
Solution
Added
--blob
flag which should be coupled with the--path
flag pointing to the blob data.