-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: feat: build the docker image for amd64 and arm64 platforms #7512
base: master
Are you sure you want to change the base?
Conversation
I'm still waiting for the workflow to pass on my repo https://github.com/Dzejkop/foundry/actions/runs/8467842044/job/23199474123 |
Marking this as a draft, please move it out of draft once you are ready for reviews :) |
good lord i need this, the emulation slowdowns have been giving us so much headache lately 😅 |
any update for this PR ? @onbjerg I have try this PR undery my fork. I found that I can't move this feature forward. because the more detail: https://github.com/Sn0rt/foundry/actions/runs/8999845047/job/24722880500 |
When will the package succeed, my local package has been compiling for 2 hours now and it's not coming out! |
@Sn0rt no update, OP has not circled back |
unfortunately this approach doubles time of building, as there's a single runner building for both platforms, we'd need something like https://docs.docker.com/build/ci/github-actions/multi-platform/#distribute-build-across-multiple-runners to parallelize them this can be tested locally by installing a registry on
|
Motivation
Using the docker image (ghcr.io/foundry-rs/foundry) on an Apple Silicon machine runs with the following warning:
and is likely suffering slowdowns due to emulation.
Solution
This PR should build the images for both amd64 and arm64 platforms