Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add skip options in checks #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

affo
Copy link

@affo affo commented Mar 10, 2020

This PR introduces options to skip some goroutines based on their stack.

Use case: I know something I depend on is leaking, or it is ok that something is leaking, and I want only to error on a precise leak.

@fortytw2
Copy link
Owner

Thanks for the PR @affo ! I totally get where you're coming from.

I think there's an issue with the design where the id in the stack will not necessarily be consistent across runs/machines in the way you expect it to be here, but I could be wrong.

I'll try to verify this in the next few days

@affo
Copy link
Author

affo commented Mar 10, 2020

@fortytw2 seems great!

Anyways I could change the option to get only the stack.
I added the id because is was available, I don't know if somebody would ever use it 🤔

@fortytw2
Copy link
Owner

If you change it to just be the stack line I think that'd be good enough @affo !

@affo
Copy link
Author

affo commented Apr 1, 2020

@fortytw2 is this good to go for you or need something else?

@affo
Copy link
Author

affo commented May 8, 2020

@fortytw2 just pinging you 😄

@fortytw2
Copy link
Owner

oh no! sorry @affo - I have an idea for this that's hard to explain but I will try to get to in the next few days, added to my todo list so I don't forget

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants