Add auto-generated social images for users #20193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhalpern
requested review from
maestromac and
lightalloy
and removed request for
a team
Codecov ReportAttention:
... and 8 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
Uffizzi Ephemeral Environment
|
klardotsh
suggested changes
Oct 2, 2023
| it "displays social image if present" do | ||
| user.profile.update(social_image: "https://socialimage.com/image.png") | ||
| get "/#{user.username}" | ||
| # Does not include the word, but does include the SVG |
There was a problem hiding this comment.
Misleading comment: This isn't an SVG. I'm also not sure what word isn't being included...
There was a problem hiding this comment.
@klardotsh sorry I think these are copy/pasted comments 🙃
|
|
||
| it "displays fallback image if social image not set" do | ||
| get "/#{user.username}" | ||
| # Does not include the word, but does include the SVG |
There was a problem hiding this comment.
What word isn't being included?
klardotsh
reviewed
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This adds a generated social image for users, re-using some functionality from what we made for articles.
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Check if Uffizzi gets this right
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.
have not been included