Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some nits in workflow lifecycle docs. #5389

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dansola
Copy link
Contributor

@dansola dansola commented May 17, 2024

Why are the changes needed?

Fixes some grammar, broken links and punctuation in the workflow lifecycle page.

What changes were proposed in this pull request?

Small nits

How was this patch tested?

N/A

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Page: https://docs.flyte.org/en/latest/concepts/workflow_lifecycle.html#understand-the-lifecycle-of-a-flyte-workflow

Signed-off-by: Daniel Sola <daniel.sola@union.ai>
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.10%. Comparing base (2f1f813) to head (2e59733).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5389      +/-   ##
==========================================
+ Coverage   61.08%   61.10%   +0.01%     
==========================================
  Files         793      793              
  Lines       51156    51156              
==========================================
+ Hits        31251    31257       +6     
+ Misses      17033    17027       -6     
  Partials     2872     2872              
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.90% <ø> (+0.04%) ⬆️
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 68.31% <ø> (ø)
unittests-flyteidl 79.30% <ø> (ø)
unittests-flyteplugins 61.94% <ø> (ø)
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib 65.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dansola dansola enabled auto-merge (squash) May 24, 2024 13:51
@dansola dansola disabled auto-merge May 24, 2024 13:52
@dansola dansola enabled auto-merge (squash) May 24, 2024 16:51
@dansola dansola disabled auto-merge May 24, 2024 16:52
@dansola dansola enabled auto-merge (squash) May 24, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants