Ensure token is refreshed on Unauthenticated #5388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5388 +/- ##
==========================================
- Coverage 61.08% 61.07% -0.02%
==========================================
Files 793 793
Lines 51156 51210 +54
==========================================
+ Hits 31251 31275 +24
- Misses 17033 17059 +26
- Partials 2872 2876 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pmahindrakar-oss
force-pushed
the
upstream-auth-token-cache-issue
branch
3 times, most recently
from
111ee95
to
8d6e360
Compare
eapolinario
reviewed
May 20, 2024
eapolinario
previously approved these changes
May 20, 2024
Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com>
Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com>
Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com>
Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com>
Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com>
pmahindrakar-oss
force-pushed
the
upstream-auth-token-cache-issue
branch
from
513b12b
to
dd47b45
Compare
eapolinario
approved these changes
May 20, 2024
|
The docs failures are unrelated. |
|
edit: I clicked the revert button on github. 😂 |
eapolinario
added a commit
that referenced
this pull request
May 21, 2024
This reverts commit 1384b32.
eapolinario
added a commit
that referenced
this pull request
May 21, 2024
pmahindrakar-oss
added a commit
that referenced
this pull request
May 22, 2024
pmahindrakar-oss
added a commit
that referenced
this pull request
May 23, 2024
pmahindrakar-oss
added a commit
that referenced
this pull request
May 31, 2024
eapolinario
added a commit
that referenced
this pull request
May 31, 2024
* Revert "Revert "Ensure token is refreshed on Unauthenticated (#5388)" (#5404)" This reverts commit 7d2f0d0. Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com> * Using same mutex for condition variable Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com> * Lock the locker in the wait to adher to cond.Wait() semantics Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com> * comments Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com> * using noop locker as waitlist add is atomic operation Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com> * Replace Azure AD OIDC URL with correct one (#4075) Signed-off-by: Erwin de Haan <erwin.de.haan@calcasa.nl> Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com> * Update the example Dockerfile to run on k8s (#5412) Signed-off-by: Jason Parraga <sovietaced@gmail.com> Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com> * docs(kubeflow): Fix kubeflow webhook error (#5410) Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com> Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com> * update flytekit version to 1.12.1b2 in monodocs requirements (#5411) Signed-off-by: Samhita Alla <aallasamhita@gmail.com> Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com> * Add supported task types to agent service config and rename (#5402) Signed-off-by: Jason Parraga <sovietaced@gmail.com> Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com> * update lock file (#5416) Signed-off-by: Samhita Alla <aallasamhita@gmail.com> Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com> * [monorepo] Fix flytectl install script (#5405) Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com> * bring in changes for flytecl keyring from PR flytectl/pull/488 Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com> * typo fix Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com> --------- Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com> Signed-off-by: Erwin de Haan <erwin.de.haan@calcasa.nl> Signed-off-by: Jason Parraga <sovietaced@gmail.com> Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com> Signed-off-by: Samhita Alla <aallasamhita@gmail.com> Co-authored-by: Erwin de Haan <1627021+EraYaN@users.noreply.github.com> Co-authored-by: Jason Parraga <Sovietaced@gmail.com> Co-authored-by: Chi-Sheng Liu <chishengliu@chishengliu.com> Co-authored-by: Samhita Alla <aallasamhita@gmail.com> Co-authored-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com>
|
Why change the interface instead of just making the implementation thread safe? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
#5387
Why are the changes needed?
Fix the unsafe threading behavior of multiple parallel client api trying to get tokens
What changes were proposed in this pull request?
Adding condition variables and mutex locks to serialize the calls
How was this patch tested?
Tested this on internal tenant by sending multiple parallel client requests and verified no issue were observed
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link