Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Bubbletea list CLI for command selecting #5357

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

zychen5186
Copy link
Contributor

@zychen5186 zychen5186 commented May 12, 2024

Tracking issue

Related to https://github.com/flyteorg/flyte/issues/<4440>

Why are the changes needed?

  1. Enhanced User Experience: Bubble Tea offers a more interactive and visually appealing interface. This enhances the overall user experience.
  2. Increased Accessibility: With Bubble Tea, we can create CLIs that are easier to navigate, especially for users who might not be familiar with command line operations. This accessibility broadens our tool's user base.

What changes were proposed in this pull request?

User can select the command they want to use through the CLI

How was this patch tested?

This feature will only be triggered when -i flag is specified

Case I tested:

./bin/flytectl -i
./bin/flytectl get -i 
./bin/flytectl get execution -p my-project  -i 
./bin/flytectl get execution -p my-project -d development -i 

Setup process

make compile

Screenshots

May-12-2024 15-43-38

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

#5310

Docs link

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.09%. Comparing base (2f1f813) to head (db07597).

Current head db07597 differs from pull request most recent head d2929a6

Please upload reports for the commit d2929a6 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5357   +/-   ##
=======================================
  Coverage   61.08%   61.09%           
=======================================
  Files         793      794    +1     
  Lines       51156    51214   +58     
=======================================
+ Hits        31251    31290   +39     
- Misses      17033    17043   +10     
- Partials     2872     2881    +9     
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.86% <ø> (ø)
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 68.30% <100.00%> (-0.02%) ⬇️
unittests-flyteidl 79.30% <ø> (ø)
unittests-flyteplugins 61.94% <ø> (ø)
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib 65.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
@zychen5186 zychen5186 mentioned this pull request Jun 1, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant