Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added a widget for Network locations #15422

Merged
merged 23 commits into from
May 20, 2024

Conversation

hishitetsu
Copy link
Member

@hishitetsu hishitetsu commented May 17, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Opened Files ...
  2. ...

Screenshots
image

@hishitetsu hishitetsu changed the title Feature: Added Network location widget Feature: Added Network locations widget May 17, 2024
@yaira2
Copy link
Member

yaira2 commented May 17, 2024

Can we remove the “map drive” button from the drives widget?

@hishitetsu
Copy link
Member Author

Can we remove the “map drive” button from the drives widget?

Removed.

@hishitetsu hishitetsu marked this pull request as ready for review May 17, 2024 16:33
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Drives to Locations is what I wanted to do in the future, so looks good.
  • INetworkService should be INetworkLocationsService (just Drives to Locations)
  • Looks like other language packs have been changed too.
  • Storage sense doesn’t need to be in network locations I believe.

src/Files.App/Services/NetworkService.cs Outdated Show resolved Hide resolved
src/Files.App/Strings/es-419/Resources.resw Outdated Show resolved Hide resolved
src/Files.App/Strings/en-US/Resources.resw Outdated Show resolved Hide resolved
src/Files.App/ViewModels/MainPageViewModel.cs Show resolved Hide resolved
@hishitetsu hishitetsu requested a review from 0x5bfa May 18, 2024 13:36
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, code wise.

@hishitetsu
Copy link
Member Author

Restored Network shell folder in the network section of the sidebar.

@hishitetsu hishitetsu requested a review from yaira2 May 19, 2024 12:46
@yaira2 yaira2 changed the title Feature: Added Network locations widget Feature: Added a widget for Network locations May 20, 2024
@yaira2 yaira2 merged commit c101ce2 into files-community:main May 20, 2024
6 checks passed
@yaira2
Copy link
Member

yaira2 commented May 20, 2024

Thank you

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 20, 2024
@hishitetsu hishitetsu deleted the NetworkWidget branch May 21, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add a widget for network drives
3 participants