Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added a tooltip when hovering over OneDrive status icons #15421

Merged
merged 4 commits into from
May 19, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented May 17, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Open Files app
  2. Go to cloud drive folder
  3. Hover on

Screenshots

image

@yaira2
Copy link
Member

yaira2 commented May 17, 2024

Is the text localized?

@0x5bfa
Copy link
Member Author

0x5bfa commented May 17, 2024

Absolutely.

As a sidenote, I wanna rename all string properties that are localized to have Humanized suffix or prefix. This makes us understand a lot easier.
You may find that 'Localized' does its job, however 'Humanized' works for broader use cases, such as '56 MiB' text. The raw data must be 58720256 long data but it's humanized for humans to get far better understanding.

@yaira2
Copy link
Member

yaira2 commented May 17, 2024

What is the text for each status?

@0x5bfa
Copy link
Member Author

0x5bfa commented May 17, 2024

IMG_0133

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Feature: Add a tooltip on the cloud drive status icon Feature: Added a tooltip when hovering over Cloud Icons May 19, 2024
@yaira2 yaira2 changed the title Feature: Added a tooltip when hovering over Cloud Icons Feature: Added a tooltip when hovering over OneDrive status icons May 19, 2024
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 19, 2024
@yaira2 yaira2 merged commit e39f2a6 into files-community:main May 19, 2024
6 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/CQ-StatusIconTooltip branch May 20, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add a tooltip on what the cloud drive status icon means
2 participants