Fix: Fixed an issue where it didn't work to map certain keys to Actions

[XTorLukas]

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

• Bug: Problem with mapping certain keys in action section #15403

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

1. Testing the correct mapping of all problem keys

[0x5bfa]

You know our codebase well!!!
LGTM. code wise.
As we are not in an area that needs unicode support, could you please send a screenshot or video recording of the validation?

[XTorLukas]

@yaira2 I found the cause of the NumKeys mapping not working, Not localized Pad0-9

Now it's worked

Testing.KeyMap.165756.mp4

[XTorLukas]

Oh, Decimal (NumPad) key not defined too

Feature

As I follow the definition of the Numpad keys at PowerToys is not bad as they define instead of "Decimal" --> ". (NumPad)"

Experimental Test

But I thought it would be enough to just localize the name 'NumPad' and the rest is default for all standards, at the same time it would be easier to know that the key is from 'NumPad'

Experimental.KeyMap.NumPad.Key.mp4

What do you think about that?

[XTorLukas]

Test own layout (cs-CZ_QWERTZ)

• All Green lines are correct
• Orange lines unused
• Red Box (Caps Lock / Scroll Lock / Num Lock) would be good to disable in the selection, because they are not possible, but they are marked as Empty string and so can be overlooked. After saving the application fails.

[XTorLukas]

Red Box (Caps Lock / Scroll Lock / Num Lock) would be good to disable in the selection, because they are not possible, but they are marked as Empty string and so can be overlooked. After saving the application fails.

Now ignored non-valid keys aka Red Box and more optimalization for speed

1. I added information about invalid key binding to give the user the option to use a different key binding.
   

2. Works also for already defined key bindings
   

3. I reworked the logic when the SaveButton and AddButton buttons are active

[XTorLukas]

Let's get to testing

• Testing functionality across different locations
  • cs-CZ
  • sk-SK
  • en-US
  • ru-RU
  • uk-UA
  • ... more
• Verification and search for possible bugs
• Finalization

[0x5bfa]

LGTM other than two things below, code wise.
I can test these on my end this weekend.

[0x5bfa]

Code Quality is over A+.
Looks great to me.

I haven't tested on my end but if someone did I think this can be merged.
If still opened, I'll test this weekend.

[XTorLukas]

Code Quality is over A+. Looks great to me.

Thank you, I'm glad I'm not a useless liability here even though I've only been in this community for a short time. I'll definitely keep trying to improve the quality of the code.

[XTorLukas]

I just have an idea for the future, it would be good to merge all the work with "Key binding" into one class and split it into functions, at least now it's too much for one method

Files/src/Files.App/Views/Settings/ActionsPage.xaml.cs

Lines 54 to 143 in d015e04

	private void KeyBindingEditorTextBox_PreviewKeyDown(object sender, KeyRoutedEventArgs e)
	{
	// Ensure the sender is a TextBox
	if (sender is not TextBox textBox)
	return;
	// Cast the DataContext of the TextBox to a ModifiableActionItem if possible, or null if the cast fails
	var item = textBox.DataContext as ModifiableActionItem;
	var pressedKey = e.OriginalKey;
	var pressedKeyValue = HotKey.LocalizedKeys.GetValueOrDefault((Keys)pressedKey);
	var buffer = new StringBuilder();
	// Define invalid keys that shouldn't be processed
	var invalidKeys = new HashSet<VirtualKey>
	{
	VirtualKey.CapitalLock,
	VirtualKey.NumberKeyLock,
	VirtualKey.Scroll,
	};
	// Define modifier keys
	var modifierKeys = new HashSet<VirtualKey>
	{
	VirtualKey.Shift,
	VirtualKey.Control,
	VirtualKey.Menu,
	VirtualKey.LeftWindows,
	VirtualKey.RightWindows,
	VirtualKey.LeftShift,
	VirtualKey.LeftControl,
	VirtualKey.RightControl,
	VirtualKey.LeftMenu,
	VirtualKey.RightMenu
	};
	// Determine if the pressed key is invalid or a modifier
	var isInvalidKey = invalidKeys.Contains(pressedKey) || string.IsNullOrEmpty(pressedKeyValue);
	var isModifierKey = modifierKeys.Contains(pressedKey);
	// Handle invalid keys that are not modifiers
	if (isInvalidKey && !isModifierKey)
	{
	InvalidKeyTeachingTip.Target = textBox;
	ViewModel.IsInvalidKeyTeachingTipOpened = true;
	}
	// Check if the pressed key is invalid, a modifier, or has no value; Don't show it in the TextBox yet
	if (isInvalidKey || isModifierKey)
	{
	// Set the text of the TextBox to the empty buffer
	textBox.Text = buffer.ToString();
	// Update UI state based on the context item
	if (item is null)
	ViewModel.EnableAddNewKeyBindingButton = false;
	else
	item.IsValidKeyBinding = false;
	// Prevent key down event in other UIElements from getting invoked
	e.Handled = true;
	return;
	}
	// Get the currently pressed modifier keys
	var pressedModifiers = HotKeyHelpers.GetCurrentKeyModifiers();
	// Append modifier keys to the buffer
	if (pressedModifiers.HasFlag(KeyModifiers.Ctrl))
	buffer.Append($"{HotKey.LocalizedModifiers.GetValueOrDefault(KeyModifiers.Ctrl)}+");
	if (pressedModifiers.HasFlag(KeyModifiers.Alt))
	buffer.Append($"{HotKey.LocalizedModifiers.GetValueOrDefault(KeyModifiers.Alt)}+");
	if (pressedModifiers.HasFlag(KeyModifiers.Shift))
	buffer.Append($"{HotKey.LocalizedModifiers.GetValueOrDefault(KeyModifiers.Shift)}+");
	// Append the pressed key to the buffer
	buffer.Append(pressedKeyValue);
	// Set the text of the TextBox to the constructed key combination
	textBox.Text = buffer.ToString();
	// Update UI state based on the context item
	if (item is null)
	ViewModel.EnableAddNewKeyBindingButton = true;
	else
	item.IsValidKeyBinding = true;
	// Prevent key down event in other UIElements from getting invoked
	e.Handled = true;
	}

[0x5bfa]

Definitely.
We might want to use MS.Windows.Interactivity, MS.Window.Interaction.Core and ViewModel.HandleEditorInputCommand or just call ViewModel.HandleEditorInput();

[XTorLukas]

Sounds good.

[yaira2]

Will this have any effect on existing users?

[XTorLukas]

Will this have any effect on existing users?

It won't be, I just fixed the correct display of mapped keys and added an informative teaching tip about invalid key binding