Add a new 'precisePreview' option #300
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Canvas context is translated by width/2, height/2 before applying transformations and should be translated back by the same values, not the rounded ones.
When true it takes rounding errors into account and makes the preview exactly match the cropped result
…recise-preview-option
Codecov Report
@@ Coverage Diff @@
## master #300 +/- ##
==========================================
- Coverage 72.63% 72.27% -0.36%
==========================================
Files 9 9
Lines 1535 1544 +9
==========================================
+ Hits 1115 1116 +1
- Misses 420 428 +8
Continue to review full report at Codecov.
|
|
@daiyam I resolved the conflicts but this PR was there for more than 3 years now w/o any attention. So I'm not sure if it's worth investing more time into adding tests as it looks like it may never be merged. |
|
@lexiv0re Thank you for the PR and the update :) |
|
Will some version of a fix like this be merged? It seems like it solves some important bugs (e.g. #551). |
fengyuanchen
force-pushed
the
main
branch
5 times, most recently
from
cb5ac44
to
aa96a51
Compare
fengyuanchen
force-pushed
the
main
branch
2 times, most recently
from
a367d75
to
3375ce0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to implement a workaround for fengyuanchen/cropper#969.
A new option is proposed to control the desired behavior. Due to the default value compatible with the existing behavior, it does not introduce any breaking changes.
With this option enabled it applies rounding in the calculation of the preview size and position similar to what being applied during the crop process.
Also, fixes inaccuracy (for images with odd height/width) in source canvas transformations (scale/rotate).