feat(cropper-selection): uses getAdjustedSizesKeepArea()
for aspectRatio calculation
#1164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopen of #1162
Previously we grow the width/height to fit with the new aspect-ratio.
This PR changes the calculation: now we changes both the width and height while keeping the original area, which in theory would fit a better UX, especially when take in account of (#1163 aspect-ratio reactivity)
Without this PR, #1163 would behave as follow: the selection area being grown out of view when input changes, especially for dynamic user inputted usage.
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of the default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
There is a behavior change, is breaking.
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: