Adding filter functionality like brightness, saturation, inversion, grayscale #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of the canvas is desynchronized, because scale factor is not considered in the initCanvas method.
|
The method initCanvas considers the rotation but not scaling. I fixed it. |
…of the canvas is desynchronized, because scale factor is not considered in the initCanvas method.
|
For filter, you can reference this example: Use Cropper with CamanJS. |
|
This is a good quality PR! I love the simplicity |
|
@fengyuanchen @oschildt hello, is this compatible with v2? Or is there any way to implement this feature into v2? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
New feature:
I have added the functionality for applying some additional effects to the image beneath rotation, flipping, resizing and cropping. That are:
Bug fix
EVENT_ZOOM should be fired after the canvas is re-rendered, otherwise the canvas data is not actual by reacting on the event.
Demo: http://www.php-smart-factory.org/cropper/
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
You have tested in the following browsers: (Providing a detailed version will be better.)