Remove dead code from et_replay/tools/et_replay.py #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
TaekyungHeo
requested review from
kingchc,
louisfeng,
sunghlin,
wfu-fb,
shengbao-zheng and
briancoutinho
as code owners
|
lgtm :) importing |
|
@briancoutinho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@briancoutinho merged this pull request in 71b2285. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove dead code from et_replay/tools/et_replay.py. I understand that et_replay should support replaying both computation operators and communication operators simultaneously. However, currently, et_replay does not properly support communication replay. As a step for refactoring, @briancoutinho commented out communication-related code from et_replay. I understand this was intended to ease the revival of the communication operator replay feature. However, this approach is not helpful because the interface to the communication operator is likely to undergo significant changes. Therefore, I am proposing this PR to remove the dead commented-out code and start from a clean slate.
Test Plan
Not needed. Removed commented-out code only.