Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor et_replay for Better Design and Maintainability #114

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Refactor et_replay for Better Design and Maintainability #114

wants to merge 1 commit into from

Conversation

TaekyungHeo
Copy link
Contributor

@TaekyungHeo TaekyungHeo commented May 10, 2024 •
edited

Summary

Refactored the et_replay module to enhance design and maintainability.

Test Plan

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 10, 2024
@TaekyungHeo TaekyungHeo changed the title Et replay refactor function Refactor Code for Improved Design and Maintainability in et_replay May 10, 2024
@TaekyungHeo TaekyungHeo changed the title Refactor Code for Improved Design and Maintainability in et_replay Refactor et_replay for Better Design and Maintainability May 10, 2024
@TaekyungHeo TaekyungHeo force-pushed the et-replay-refactor-function branch 22 times, most recently from 90685d5 to 0d91353 Compare May 17, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingchc kingchc Awaiting requested review from kingchc kingchc will be requested when the pull request is marked ready for review kingchc is a code owner

@louisfeng louisfeng Awaiting requested review from louisfeng louisfeng will be requested when the pull request is marked ready for review louisfeng is a code owner

@sunghlin sunghlin Awaiting requested review from sunghlin sunghlin will be requested when the pull request is marked ready for review sunghlin is a code owner

@wfu-fb wfu-fb Awaiting requested review from wfu-fb wfu-fb will be requested when the pull request is marked ready for review wfu-fb is a code owner

@shengbao-zheng shengbao-zheng Awaiting requested review from shengbao-zheng shengbao-zheng will be requested when the pull request is marked ready for review shengbao-zheng is a code owner

@briancoutinho briancoutinho Awaiting requested review from briancoutinho briancoutinho will be requested when the pull request is marked ready for review briancoutinho is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TaekyungHeo @facebook-github-bot