Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve defaultProps of class components in JSX runtime #29101

Closed
wants to merge 3 commits into from

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented May 16, 2024

No description provided.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 16, 2024
@react-sizebot
Copy link

Comparing: a0eb265...e23044c

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 495.01 kB 495.01 kB = 88.68 kB 88.68 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 499.81 kB 499.81 kB = 89.36 kB 89.36 kB
facebook-www/ReactDOM-prod.classic.js = 592.16 kB 592.16 kB = 104.15 kB 104.15 kB
facebook-www/ReactDOM-prod.modern.js = 568.39 kB 568.39 kB = 100.55 kB 100.55 kB
oss-experimental/react/cjs/react-jsx-runtime.profiling.js +30.46% 0.98 kB 1.27 kB +15.66% 0.50 kB 0.58 kB
oss-stable-semver/react/cjs/react-jsx-runtime.profiling.js +30.46% 0.98 kB 1.27 kB +15.66% 0.50 kB 0.58 kB
oss-stable/react/cjs/react-jsx-runtime.profiling.js +30.46% 0.98 kB 1.27 kB +15.66% 0.50 kB 0.58 kB
oss-experimental/react/cjs/react-jsx-runtime.production.js +30.43% 0.98 kB 1.27 kB +15.63% 0.50 kB 0.58 kB
oss-stable-semver/react/cjs/react-jsx-runtime.production.js +30.43% 0.98 kB 1.27 kB +15.63% 0.50 kB 0.58 kB
oss-stable/react/cjs/react-jsx-runtime.production.js +30.43% 0.98 kB 1.27 kB +15.63% 0.50 kB 0.58 kB
oss-experimental/react/cjs/react-jsx-runtime.react-server.production.js +22.64% 1.31 kB 1.61 kB +11.60% 0.68 kB 0.76 kB
oss-stable-semver/react/cjs/react-jsx-runtime.react-server.production.js +22.64% 1.31 kB 1.61 kB +11.60% 0.68 kB 0.76 kB
oss-stable/react/cjs/react-jsx-runtime.react-server.production.js +22.64% 1.31 kB 1.61 kB +11.60% 0.68 kB 0.76 kB
oss-experimental/react/cjs/react-jsx-dev-runtime.react-server.production.js +22.57% 1.32 kB 1.61 kB +11.40% 0.68 kB 0.76 kB
oss-stable-semver/react/cjs/react-jsx-dev-runtime.react-server.production.js +22.57% 1.32 kB 1.61 kB +11.40% 0.68 kB 0.76 kB
oss-stable/react/cjs/react-jsx-dev-runtime.react-server.production.js +22.57% 1.32 kB 1.61 kB +11.40% 0.68 kB 0.76 kB
oss-stable-semver/react/cjs/react.react-server.production.js +5.39% 14.96 kB 15.77 kB +4.20% 4.07 kB 4.24 kB
oss-stable/react/cjs/react.react-server.production.js +5.38% 14.98 kB 15.79 kB +4.25% 4.09 kB 4.27 kB
oss-stable-semver/react/cjs/react.production.js +4.78% 16.87 kB 17.67 kB +3.87% 4.39 kB 4.56 kB
oss-stable/react/cjs/react.production.js +4.77% 16.89 kB 17.69 kB +3.83% 4.42 kB 4.59 kB
oss-experimental/react/cjs/react.production.js +4.50% 17.91 kB 18.72 kB +3.65% 4.66 kB 4.83 kB
oss-experimental/react/cjs/react.react-server.production.js +4.33% 18.62 kB 19.42 kB +3.47% 4.96 kB 5.13 kB
facebook-www/React-prod.modern.js +2.61% 23.10 kB 23.70 kB +2.09% 5.93 kB 6.06 kB
facebook-www/React-prod.classic.js +2.61% 23.10 kB 23.70 kB +2.07% 5.93 kB 6.06 kB
facebook-react-native/react/cjs/React-prod.js +2.60% 23.20 kB 23.81 kB +2.01% 5.97 kB 6.09 kB
facebook-www/React-profiling.modern.js +2.57% 23.53 kB 24.14 kB +2.11% 6.01 kB 6.13 kB
facebook-www/React-profiling.classic.js +2.57% 23.53 kB 24.14 kB +2.11% 6.01 kB 6.14 kB
facebook-react-native/react/cjs/React-profiling.js +2.56% 23.64 kB 24.24 kB +1.99% 6.04 kB 6.16 kB
facebook-react-native/react/cjs/JSXRuntime-prod.js +2.08% 4.19 kB 4.28 kB +1.80% 1.50 kB 1.53 kB
facebook-react-native/react/cjs/JSXRuntime-profiling.js +2.08% 4.19 kB 4.28 kB +1.80% 1.50 kB 1.53 kB
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react/cjs/react-jsx-runtime.profiling.js +30.46% 0.98 kB 1.27 kB +15.66% 0.50 kB 0.58 kB
oss-stable-semver/react/cjs/react-jsx-runtime.profiling.js +30.46% 0.98 kB 1.27 kB +15.66% 0.50 kB 0.58 kB
oss-stable/react/cjs/react-jsx-runtime.profiling.js +30.46% 0.98 kB 1.27 kB +15.66% 0.50 kB 0.58 kB
oss-experimental/react/cjs/react-jsx-runtime.production.js +30.43% 0.98 kB 1.27 kB +15.63% 0.50 kB 0.58 kB
oss-stable-semver/react/cjs/react-jsx-runtime.production.js +30.43% 0.98 kB 1.27 kB +15.63% 0.50 kB 0.58 kB
oss-stable/react/cjs/react-jsx-runtime.production.js +30.43% 0.98 kB 1.27 kB +15.63% 0.50 kB 0.58 kB
oss-experimental/react/cjs/react-jsx-runtime.react-server.production.js +22.64% 1.31 kB 1.61 kB +11.60% 0.68 kB 0.76 kB
oss-stable-semver/react/cjs/react-jsx-runtime.react-server.production.js +22.64% 1.31 kB 1.61 kB +11.60% 0.68 kB 0.76 kB
oss-stable/react/cjs/react-jsx-runtime.react-server.production.js +22.64% 1.31 kB 1.61 kB +11.60% 0.68 kB 0.76 kB
oss-experimental/react/cjs/react-jsx-dev-runtime.react-server.production.js +22.57% 1.32 kB 1.61 kB +11.40% 0.68 kB 0.76 kB
oss-stable-semver/react/cjs/react-jsx-dev-runtime.react-server.production.js +22.57% 1.32 kB 1.61 kB +11.40% 0.68 kB 0.76 kB
oss-stable/react/cjs/react-jsx-dev-runtime.react-server.production.js +22.57% 1.32 kB 1.61 kB +11.40% 0.68 kB 0.76 kB
oss-stable-semver/react/cjs/react.react-server.production.js +5.39% 14.96 kB 15.77 kB +4.20% 4.07 kB 4.24 kB
oss-stable/react/cjs/react.react-server.production.js +5.38% 14.98 kB 15.79 kB +4.25% 4.09 kB 4.27 kB
oss-stable-semver/react/cjs/react.production.js +4.78% 16.87 kB 17.67 kB +3.87% 4.39 kB 4.56 kB
oss-stable/react/cjs/react.production.js +4.77% 16.89 kB 17.69 kB +3.83% 4.42 kB 4.59 kB
oss-experimental/react/cjs/react.production.js +4.50% 17.91 kB 18.72 kB +3.65% 4.66 kB 4.83 kB
oss-experimental/react/cjs/react.react-server.production.js +4.33% 18.62 kB 19.42 kB +3.47% 4.96 kB 5.13 kB
facebook-www/React-prod.modern.js +2.61% 23.10 kB 23.70 kB +2.09% 5.93 kB 6.06 kB
facebook-www/React-prod.classic.js +2.61% 23.10 kB 23.70 kB +2.07% 5.93 kB 6.06 kB
facebook-react-native/react/cjs/React-prod.js +2.60% 23.20 kB 23.81 kB +2.01% 5.97 kB 6.09 kB
facebook-www/React-profiling.modern.js +2.57% 23.53 kB 24.14 kB +2.11% 6.01 kB 6.13 kB
facebook-www/React-profiling.classic.js +2.57% 23.53 kB 24.14 kB +2.11% 6.01 kB 6.14 kB
facebook-react-native/react/cjs/React-profiling.js +2.56% 23.64 kB 24.24 kB +1.99% 6.04 kB 6.16 kB
facebook-react-native/react/cjs/JSXRuntime-prod.js +2.08% 4.19 kB 4.28 kB +1.80% 1.50 kB 1.53 kB
facebook-react-native/react/cjs/JSXRuntime-profiling.js +2.08% 4.19 kB 4.28 kB +1.80% 1.50 kB 1.53 kB
oss-stable-semver/react/cjs/react-jsx-dev-runtime.development.js +1.06% 41.43 kB 41.87 kB +0.73% 12.53 kB 12.62 kB
oss-stable/react/cjs/react-jsx-dev-runtime.development.js +1.06% 41.43 kB 41.87 kB +0.73% 12.53 kB 12.62 kB
oss-experimental/react/cjs/react-jsx-dev-runtime.development.js +1.03% 42.58 kB 43.02 kB +0.78% 12.72 kB 12.82 kB
oss-stable-semver/react/cjs/react-jsx-runtime.development.js +1.03% 42.66 kB 43.10 kB +0.76% 12.87 kB 12.97 kB
oss-stable/react/cjs/react-jsx-runtime.development.js +1.03% 42.66 kB 43.10 kB +0.76% 12.87 kB 12.97 kB
oss-stable-semver/react/cjs/react-jsx-runtime.react-server.development.js +1.02% 43.07 kB 43.51 kB +0.75% 13.00 kB 13.10 kB
oss-stable/react/cjs/react-jsx-runtime.react-server.development.js +1.02% 43.07 kB 43.51 kB +0.75% 13.00 kB 13.10 kB
oss-stable-semver/react/cjs/react-jsx-dev-runtime.react-server.development.js +1.02% 43.07 kB 43.51 kB +0.75% 13.00 kB 13.10 kB
oss-stable/react/cjs/react-jsx-dev-runtime.react-server.development.js +1.02% 43.07 kB 43.51 kB +0.75% 13.00 kB 13.10 kB
oss-experimental/react/cjs/react-jsx-runtime.development.js +1.00% 43.81 kB 44.25 kB +0.69% 13.07 kB 13.16 kB
oss-experimental/react/cjs/react-jsx-runtime.react-server.development.js +0.99% 44.21 kB 44.65 kB +0.68% 13.20 kB 13.29 kB
oss-experimental/react/cjs/react-jsx-dev-runtime.react-server.development.js +0.99% 44.22 kB 44.66 kB +0.68% 13.20 kB 13.29 kB
oss-stable-semver/react/cjs/react.react-server.development.js +0.77% 69.07 kB 69.60 kB +0.62% 19.31 kB 19.43 kB
oss-stable/react/cjs/react.react-server.development.js +0.77% 69.09 kB 69.62 kB +0.62% 19.34 kB 19.46 kB
oss-experimental/react/cjs/react.react-server.development.js +0.70% 75.89 kB 76.42 kB +0.48% 21.12 kB 21.22 kB
oss-stable-semver/react/cjs/react.development.js +0.57% 93.37 kB 93.90 kB +0.37% 25.58 kB 25.68 kB
oss-stable/react/cjs/react.development.js +0.57% 93.40 kB 93.93 kB +0.38% 25.61 kB 25.71 kB
oss-experimental/react/cjs/react.development.js +0.55% 96.09 kB 96.62 kB +0.40% 26.16 kB 26.27 kB
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Generated by 🚫 dangerJS against e23044c

@eps1lon
Copy link
Collaborator Author

eps1lon commented May 17, 2024

Libraries reading from children.props should resolve defaultProps themselves via const childProps = { ...child.type.defaultProps, ...child.props}

@eps1lon eps1lon closed this May 17, 2024
@eps1lon eps1lon deleted the defaultprops branch May 17, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants