Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextInput - selection prop is not set on component creation #44398

Closed
wants to merge 1 commit into from

Commits on May 3, 2024

  1. TextInput - selection prop is not set on component creation

    Summary:
    **Problem:**
    `selection` prop is not being set on component creation.
    Not quite sure which RN version this issue was introduced but fixing it on latest code.
    
    Use playground for testing (refer to following diff)
    
    **Proposed Solution:**
    
    Added notes in comments but `viewCommands.setTextAndSelection()` is called only on text or selection update which relies on comparing data with `lastNativeSelection`. Problem is that `lastNativeSelection` is initially set to the props value that is passed in so does not send the command on component creation.
    
    So assign a default selection value of `{start: -1, end: -1}` so it can be set on component creation.
    
    
    **Changelog:**
    [General][Fixed] - `selection` prop in `TextInput` was not being applied at component creation
    
    Differential Revision: D56911712
    alanleedev authored and facebook-github-bot committed May 3, 2024
    Configuration menu
    Copy the full SHA
    478bbfe View commit details
    Browse the repository at this point in the history