Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<ScrollView/>: Add static ViewConfig for scrollEventThrottle #44366

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

RSNara
Copy link
Contributor

@RSNara RSNara commented May 2, 2024

Summary:
This prop was introduced into horizontal in D35735978.

Note: This prop does not work for bridgeless mode.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D56854758

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels May 2, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56854758

@analysis-bot
Copy link

analysis-bot commented May 2, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,527,883 +8
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,900,316 -1
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 185f63b
Branch: main

RSNara added 10 commits May 2, 2024 10:17
Summary: Changelog: [Internal]

Differential Revision: D56831755

Reviewed By: javache
Summary:
experimental_layoutConformance was added in this diff: D47940100

Changelog: [Internal]

Differential Revision: D56849869
Summary:
collapsableChildren was introduced in D56226241

Changelog: [Internal]

Differential Revision: D56849868
Summary:
onClick was made into a capture event in this diff: D45745906
- Partial fix: D51551255
- Full fix: this diff.

**Note:** This prop did not work for bridgeless mode.

Changelog: [Internal]

Differential Revision: D56849867

Reviewed By: javache
Summary:
The insets props were introduced in this diff: D42193661

Changelog: [Internal]

Differential Revision: D56849870
Summary:
The margin/padding props were introduced in this diff: D41267765

Changelog: [Internal]

Differential Revision: D56846578
Summary:
<Image/>'s source prop was introduced in D51479305.

Changelog: [Internal]

Differential Revision: D56831756

Reviewed By: javache
Summary:
horizontal was introduced here: D55367445

Changelog: [Internal]

Differential Revision: D56831754

Reviewed By: javache
Summary:
This prop was introduced for horizontal and vertical scrollview in D40642469.

That diff updated the native view configs only.

**Note:** This prop did not work for bridgeless mode.

Partial fix: Add the prop to vertical scrollview: D54223244

Full fix: this diff.

Changelog: [Internal]

Differential Revision: D56854757

Reviewed By: javache
Summary:
This prop was introduced into horizontal <ScrollView/> in D35735978.

**Note:** This prop did not work for bridgeless mode.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D56854758
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56854758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants